[Webkit-unassigned] [Bug 34317] [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's network infrastructure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34317





--- Comment #6 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-30 02:45:06 PST ---
Attachment 47761 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
gtk/WebKitWebSourceGStreamer.cpp:560:  webkit_web_src_set_frame is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:562:  Declaration
has space between type name and * in WebkitWebSrcPrivate *priv 
[whitespace/declaration] [3]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:584:  Declaration
has space between type name and * in WebkitWebSrcPrivate *priv 
[whitespace/declaration] [3]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:590:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:602:  Extra space
before ( in function call  [whitespace/parens] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:602:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:607:  Declaration
has space between type name and * in gchar *endptr  [whitespace/declaration]
[3]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:607:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:608:  icy_metaint is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:611:  Declaration
has space between type name and * in GstCaps *caps  [whitespace/declaration]
[3]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:611:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:624:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:631:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:638:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:645:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:656:  Declaration
has space between type name and * in WebkitWebSrcPrivate *priv 
[whitespace/declaration] [3]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:665:  Declaration
has space between type name and * in GstBuffer *buffer 
[whitespace/declaration] [3]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:674:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:675:  One line
control clauses should not use braces.  [whitespace/braces] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:687:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:46:  Alphabetical
sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:145:  Tab found;
better to use spaces  [whitespace/tab] [1]
Total errors found: 138


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.