[Webkit-unassigned] [Bug 34343] Client-based Geolocation starts updating before getting consent from the user

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34343


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47732|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-01-29 13:45:23 PST ---
(From update of attachment 47732)
> +            ASSERT(m_frame);
> +            Page* page = m_frame->page();
> +            ASSERT(page);
> +            page->geolocationController()->addObserver(this);

What guarantees they are non-zero? You should figure out what the right
behavior would be in those cases and handle instead of asserting.

Otherwise, r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.