[Webkit-unassigned] [Bug 34019] Custom-written JavaScript parser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 06:28:51 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34019





--- Comment #30 from Zoltan Herczeg <zherczeg at webkit.org>  2010-01-29 06:28:48 PST ---
(In reply to comment #24)
> (From update of attachment 47525 [details])
> I don't like the
> case '-': ....
> case '{': ...
> etc

Done. I also found another two errors in my parser: "for (a,b in c ; ;) {}"
accepted, and "if (a) function f() {}" caused segfault. Both of them fixed
(these were minor bugs, only 1 line change was required). Now all jscore and
layout tests are passed successfully. Finally :)

> We also need to get the full set of tests to parse correctly.  Then we need to
> fuzz this (we don't have many -- if any -- invalid script tests alas)

I have attached a new patch here. It contains about 250 strings, half of them
valid JavaScript source code, and the other half is not. The strings were
tested as plain stings, and a "function f() {}" function declaration is added
around them. This is useful, since for example "return 6+" fails with syntax
error in the bison test, while "function f() { return 6+ }" is not.

I hope the patch is not far from final. Hard to update this amount of code
again and again :) When it reaches nearly finished state, I will add a
ChangeLog entry and update the mac project rules.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list