[Webkit-unassigned] [Bug 34324] New: Web Inspector: Inspector shouldn’t have a fixed list of supported Mac OS X versions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34324

           Summary: Web Inspector: Inspector shouldn’t have a fixed list
                    of supported Mac OS X versions
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mrowe at apple.com
                CC: timothy at hatcher.name, rik at webkit.org,
                    keishi at webkit.org, pmuellr at yahoo.com,
                    joepeck at webkit.org, pfeldman at chromium.org,
                    bweinstein at apple.com


Many CSS rules in the inspector are set up such that they need to be enumerated
for each Mac OS X version.  An example (which appears to be broken for
SnowLeopard?):

body.platform-mac-tiger .toolbar-item.close-right, body.platform-mac-leopard
.toolbar-item.close-right { 
    display: none;
}

This approach is not at all forward-looking, and does not match the flexible
approach that we use for handling multiple Mac OS X versions elsewhere in the
WebKit codebase.  The strategy that we use for this is that the default
behavior of the code is written for the latest Mac OS X version, and older
versions are special-cased where needed.  In particular, this means that one
will *not* find code of the form:

#if MAC_OS_X_VERSION == LATEST_VERSION_AT_THE_TIME_I_WROTE_THIS
[ behavior for new versions ]
#else
[ behavior for old versions ]
#endif

Code of this form would become wrong and require updating the second that
LATEST_VERSION_AT_THE_TIME_I_WROTE_THIS is no longer the latest version of Mac
OS X.  By enumerating Mac OS X versions in this manner in the inspector you’re
doing something that has the same result as this bad code, namely that as soon
as a new Mac OS X version is created the many locations that enumerate Mac OS X
versions would need to be updated to accommodate it otherwise it would see
unexpected behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.