[Webkit-unassigned] [Bug 34302] RenderVideo should prefer provided width/height properties to hard coded defaults when natural size is unavailable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34302


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47669|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2010-01-28 21:42:47 PST ---
(From update of attachment 47669)
>          // size since they also have audio thrown at them. By setting the intrinsic
>          // size to 300x1 the video will resize itself in these cases, and audio will
>          // have the correct height (it needs to be > 0 for controls to render properly).
> -        if (video->ownerDocument() && video->ownerDocument()->isMediaDocument())
> +        if (video->hasAttribute(widthAttr) && video->hasAttribute(heightAttr))
> +            setIntrinsicSize(IntSize(video->width(), video->height()));
> +        else if (video->ownerDocument() && video->ownerDocument()->isMediaDocument())

This comment doesn't make sense now, it is about the second test. Please add a
comment about the logic in the first test ("Prefer provided video element
width/height properties...") and move this comment down to be with the second
test.

r=me with this change

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.