[Webkit-unassigned] [Bug 33405] [OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 28 18:53:08 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33405


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47659|review?                     |review+
               Flag|                            |




--- Comment #14 from Nikolas Zimmermann <zimmermann at kde.org>  2010-01-28 18:53:06 PST ---
(From update of attachment 47659)
r=me, nice patch! Please fix some last style issues before landing:
 330     inline bool strokeDisabled() const
 331     {
 332         return (compositeOperation == CompositeSourceOver
 333             && (strokeStyle == NoStroke || !strokeColor.alpha()));
 334     }
 335 
 336     inline bool fillDisabled() const
 337     {
 338         return (compositeOperation == CompositeSourceOver &&
!fillColor.alpha());
 339     }
 340 };
Outer parenthesis shoul dbe removed.

 88     void drawRect(const FloatRect&, VGbitfield paintModes = (VG_STROKE_PATH
| VG_FILL_PATH));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list