[Webkit-unassigned] [Bug 21840] execCommand insertImage inserts image into wrong place

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21840





--- Comment #8 from Eric Seidel <eric at webkit.org>  2010-01-28 18:44:36 PST ---
(From update of attachment 47595)
Bah. Chrome/WebKit lost all my work I had typed into this field. :(

My comments again, in brief:
- ChangeLog needs information as to what your rebaseline changes are?  I don't
understand why we're adding SPANs in some tests, etc.
- Tests are clearer when they include the expected results in them, and print
PASS/FAIL.  backspace-avoid-preceding-style.html does not include its own
expected results (it's OK as is, but could be better).
- I think I would have split this while() out into early returns:
 110     while (!pos.node()->hasTagName(brTag) && enclosing != pos.node() &&
VisiblePosition(pos) == VisiblePosition(pos.next()))
- What happens in the "return pos" case?  Should we ASSERT then?  Isn't that
someone calling this function with an invalid position?  Or certainly there is
a case where we try to walk out of the current position, and we should ASSERT
then, no?
- It's not clear to me why enclosingBlockFlowElement is the right way to avoid
the preceding nodes.

Why isn't this just the downstream position?  Or maybe I'm mixing my terms.  I
think downstream positions are same equivalent visible position but the "last"
position inside that equivilancy set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.