[Webkit-unassigned] [Bug 33840] Provide a way to get page number with layoutTestController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33840


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47500|review?                     |review-
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2010-01-28 18:24:49 PST ---
(From update of attachment 47500)
Why not use a FloatSize here?
 83 void PrintContext::computePageRectsWithPageSize(float pageWidth, float
pageHeight, float userScaleFactor)

And what are the units?  Pixels?

85      float printedPagesHeight = 0.0;
 102     float printedPagesHeight = 0;
Is the compiler smart enough to amke that 0.0f?

Likewise here?
 92     if (userScaleFactor <= 0) {
0.0f?
(the compiler may be smart, I don't know).

FloatRect?
 56     void computePageRectsWithPageSize(float pageWidth, float pageHeight,
float userScaleFactor);

Why?
2   * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.
 2  * copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.

What do these defaults mean?
 469     float pageWidth = 982;
 470     float pageHeight = 1291;

I think it's a nice feature that pageNumberForElementById now takes a
width/height, and I'm glad they're not required.  I'm not sure why the various
tests use that feature, and I'm also confused by the default values and the
units.

r- mostly due to my confusion.  I think we need a few more uses of FloatSize,
and we should consider making these variable names carry units in their name. 
Like pageSizeInPixels?  or pageSizeInInches?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.