[Webkit-unassigned] [Bug 32834] svn-apply should handle git patches with similarity index, rename and copy directives

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32834





--- Comment #6 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-01-28 08:51:56 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > It'd be great if you could post the example here.  I think I know what you're
> > referring to, but it's always best to have a concrete example.
> 
> Here is a concrete example (same submitter on same day):
> 
> https://bugs.webkit.org/show_bug.cgi?id=34249#c1
> 
> https://bug-34249-attachments.webkit.org/attachment.cgi?id=47606
> 
> I needed to manually commit it since I had to make changes anyways.

This one is relatively minor.  If you have a patch series with the same
date/author/email line followed by the same "Reviewed by NOBODY(OOPS!)." line,
then you'll have even more of an offset.  (FWIW, this is another reason I like
bug titles before the "Reviewed by" line, but that's really neither here nor
there.)

> > - There is no "loss of information" if the unaltered ChangeLog patch is not
> > fixed up, and it may optionally be fixed up at any point in the future.  All
> > the pieces are there, just not in the optimal order for applying it to the top
> > of the ChangeLog file.
> > 
> > - The commit queue uses svn-apply to apply patches which fixes up the ChangeLog
> > patch before applying it.  Individual contributors may also be using svn-apply
> > to apply patches, or they may be using resolve-ChangeLogs afterwards.
> 
> If this is the case, it seems like it might not be necessary to call
> fixChangeLogPatch in svn-create-patch.

It's nice to clean up the ChangeLog patches, though, as long as you're using
svn-create-patch.  The corrected patch shows the intent of the ChangeLog patch
much better than the uncorrected version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.