[Webkit-unassigned] [Bug 34193] webkit-patch: Hangs on bad bugzilla username and completes?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34193


Chris Jerdonek <cjerdonek at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cjerdonek at webkit.org




--- Comment #5 from Chris Jerdonek <cjerdonek at webkit.org>  2010-01-28 01:48:42 PST ---
(In reply to comment #3)
> (From update of attachment 47530 [details])
> Clearing flags on attachment: 47530
> 
> Committed r53976: <http://trac.webkit.org/changeset/53976>

Thanks a lot for addressing this so quickly!

I mentioned a couple other things though--

> It's bad because there is no line of
> output saying anything like "Committed revision...." -- only "Processing
> patch 47411 from bug 34060."  It's hard to know this means "committed"
> because the next output line says it is parsing the Changelog.  It seems
> like the ChangeLog would be parsed before it starts committing.  It
> would also be good if the error says what remaining steps didn't
> complete, so the user knows what remaining steps need to be manually
> completed.

And Joe, you acknowledged that this is a "first cut".

Could you preserve the other suggestions in a report that is not marked
RESOLVED (or alternatively, re-open this one), or explain why the commit makes
it unnecessary to address the other suggestions?  Thanks a lot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.