[Webkit-unassigned] [Bug 34019] Custom-written JavaScript parser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34019


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47525|review?                     |review-
               Flag|                            |




--- Comment #24 from Oliver Hunt <oliver at apple.com>  2010-01-27 15:54:36 PST ---
(From update of attachment 47525)
I don't like the
case '-': ....
case '{': ...
etc

idiom. You should stick to the symbolic names like OPENBRACE -- this will also
reduce the lexer diffs, and reduce the risk of accidentally introducing a
symbolic name that overloads a character.

We also need to get the full set of tests to parse correctly.  Then we need to
fuzz this (we don't have many -- if any -- invalid script tests alas)

--Oliver

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.