[Webkit-unassigned] [Bug 31586] [GTK] set playbin mute property depending on volume value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31586


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47533|review?                     |review-
               Flag|                            |




--- Comment #32 from Eric Carlson <eric.carlson at apple.com>  2010-01-27 15:52:45 PST ---
(From update of attachment 47533)
> +    virtual bool supportsMuting() const { return false; }
> +    virtual void setMuted(bool) { }
> 
These methods are unnecessary because MediaPlayerPrivateInterface has default
implementations. I know that many other methods in NullMediaPlayerPrivate use
this pattern, but we should change the pattern (and come back and clean this
up).

> diff --git a/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h 
> diff --git a/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm 
> diff --git a/WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp 
> diff --git a/WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.h 
> diff --git a/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp 
> diff --git a/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h 
> diff --git a/WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h 
> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> diff --git a/WebKit/chromium/public/WebMediaPlayerClient.h 
> diff --git a/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 
> diff --git a/WebKit/chromium/src/WebMediaPlayerClientImpl.h 
None of these is necessary as each media engine subclasses
MediaPlayerPrivateInterface, which has default implementation for both methods.
I would prefer that we leave them out for now and add them when a port adds the
functionality.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.