[Webkit-unassigned] [Bug 34209] rangeOverflow/rangeUnderflow support for type=date

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34209


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47513|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-01-27 15:47:04 PST ---
(From update of attachment 47513)
> +    // Parses the src for the current type, and return the double
> +    // value for the parsing result if the parsing succeeds; Returns
> +    // defaultValue otherwise. This function can return NaN or
> +    // Infinity only if defaultValue is NaN or Infinity.
> +    double doubleValueFor(const String& src, double defaultValue) const;

If you think that the argument name is really needed, then please use the word
"source" instead of the abbreviation "src". I think you can omit the argument
name.

Might be nicer if this function name made it clearer it was a string parser.
I'm not sure "double value for <xxx>" implies parsing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.