[Webkit-unassigned] [Bug 26083] How to access formatted Java script Console message ?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26083


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41397|review?                     |review-
               Flag|                            |




--- Comment #8 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-01-27 15:38:18 PST ---
(From update of attachment 41397)
I think this patch should have LayoutTests (fast/dom/Window/console*); this
would also help to communicate the motivation behind the patch. 

> Index: WebKit/qt/Api/qwebpage.h
> ===================================================================
> --- WebKit/qt/Api/qwebpage.h	(revision 48300)
> +++ WebKit/qt/Api/qwebpage.h	(working copy)
> @@ -338,7 +338,7 @@ protected:
>      virtual void javaScriptAlert(QWebFrame *originatingFrame, const QString& msg);
>      virtual bool javaScriptConfirm(QWebFrame *originatingFrame, const QString& msg);
>      virtual bool javaScriptPrompt(QWebFrame *originatingFrame, const QString& msg, const QString& defaultValue, QString* result);
> -    virtual void javaScriptConsoleMessage(const QString& message, int lineNumber, const QString& sourceID);
> +    virtual void javaScriptConsoleMessage(const QString& messageSource, const QString& messageLevel, const QString& message, int lineNumber, const QString& sourceID);
>  
>      virtual QString userAgentForUrl(const QUrl& url) const;
>  

This change breaks backward compatibility for the QtWebKit API as it changes
the type of the second argument. 

r- for lack of tests and BC break.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.