[Webkit-unassigned] [Bug 33180] [Qt] Support private browsing mode in plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33180


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47448|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Simon Hausmann <hausmann at webkit.org>  2010-01-27 14:56:22 PST ---
(From update of attachment 47448)

> +    case NPNVprivateModeBool: {
> +        Page* page = m_parentFrame->page();
> +        if (!page)
> +            return NPERR_GENERIC_ERROR;
> +        *((NPBool*)value) = !page->settings() || page->settings()->privateBrowsingEnabled();
> +        return NPERR_NO_ERROR;
> +    }

r=me, but when landing you may want to change the above to return
NPERR_GENERIC_ERROR if !page->settings() and only return the real value to the
plugin if we have a settings object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.