[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33096


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47552|review?                     |review-
               Flag|                            |




--- Comment #47 from Simon Hausmann <hausmann at webkit.org>  2010-01-27 14:15:55 PST ---
(From update of attachment 47552)
>  void DumpRenderTree::open(const QUrl& aurl)
>  {
> +    static bool previousTestUsedWebInspector = false;
> +

A boolean is better, but my main complaint was the fact that you're using a
global object to represent state that can be stored in a simple member variable
of the DumpRenderTree class :)

Please make it a member variable.

Come to think of it: Is a boolean needed at all? Can't you simply check the
currently loaded URL, i.e.

    if (isWebInspectorTest(m_page->mainFrame()->url()))
        layoutTestController()->closeWebInspector();

>      resetToConsistentStateBeforeTesting();
>  
>      QUrl url = aurl;
> +    if (previousTestUsedWebInspector)
> +        layoutTestController()->closeWebInspector();
> +
> +    if (isWebInspectorTest(url)) {
> +        layoutTestController()->showWebInspector();
> +        previousTestUsedWebInspector = true;
> +    }
> +
>      m_expectedHash = QString();
>      if (m_dumpPixels) {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.