[Webkit-unassigned] [Bug 34173] style tool: Improve treatment of conditions and rest of the line for if, else, switch and alikes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34173





--- Comment #8 from David Levin <levin at chromium.org>  2010-01-27 10:12:25 PST ---
(In reply to comment #4)
> (In reply to comment #2) 
> > Also, if you haven't done yet, please run your modified style checker for a
> > bunch of code and check if there are no false alarms.
> 
> How can I do it?  Running against full source tree seems kind of useless---too
> difficult to say noise from real problems?  Is there some other approach?

Personally when I do a change of this sort, 
1. I run it against a lot of WebKit code (WebCore and JavaScriptCore). 
2. If there are warnings, I'll randomly check around 5 of them to ensure that
they are real warnings.
3. If any warnings are false positives, then the checker should be fixed and
this process repeated (go to step 1).
It may seem like a bit of overhead but it is worse to accidently flag correct
code and then have to deal with people's frustration with that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.