[Webkit-unassigned] [Bug 34210] [Qt] Display page loading progress inside the QtLauncher location bar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34210


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47514|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2010-01-27 08:00:37 PST ---
(From update of attachment 47514)

> +class LocationEdit : public QLineEdit {
> +    Q_OBJECT
> +public:
> +    LocationEdit(QWidget *parent = 0)

Coding style: * placement is wrong.

> +protected:
> +    virtual void paintEvent(QPaintEvent *event)

Ditto.


> +#ifndef Q_WS_MAEMO_5
>          statusBar()->showMessage(link);
> +#endif
>  #ifndef QT_NO_TOOLTIP
>          if (!toolTip.isEmpty())
>              QToolTip::showText(QCursor::pos(), toolTip);
> @@ -410,7 +453,9 @@ protected slots:
>              QWebElementCollection result =  view->page()->mainFrame()->findAllElements(str);
>              foreach (QWebElement e, result)
>                  e.setStyleProperty("background-color", "yellow");
> +#ifndef Q_WS_MAEMO_5
>              statusBar()->showMessage(QString("%1 element(s) selected").arg(result.count()), 5000);
> +#endif

While I agree with the above two hunks (the flicker in the status bar is
annoying), but technically that's unrelated to the progress bar stuff, no?

I suggest to mention it at least in the changelog.


The rest looks good to me :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.