[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33096


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47437|review?                     |review-
               Flag|                            |




--- Comment #45 from Simon Hausmann <hausmann at webkit.org>  2010-01-27 01:56:50 PST ---
(From update of attachment 47437)

> +void QWEBKIT_EXPORT qt_drt_webinspector_executeScript(QWebPage* page, long callId, const QString &script)

Coding style nitpick :) (& placement)

>  void DumpRenderTree::open(const QUrl& aurl)
>  {
> +    static QUrl url(aurl);
> +
>      resetToConsistentStateBeforeTesting();
>  
> -    QUrl url = aurl;
> +    if (isWebInspectorTest(url))
> +        layoutTestController()->closeWebInspector();
> +
> +    url = aurl;
> +
> +    if (isWebInspectorTest(url))
> +        layoutTestController()->showWebInspector();
> +

Please don't use a global QUrl object to maintain whether the inspector should
be closed on the next run or not.

I suggest either a boolean (where the name indicates what's happening), or see
if I can tie it to some other property,
for example to whether DeveloperExtras are enabled or not. That is unless you'd
like to show it once the inspector tests being, keep it "visible" and then
close it once the last inspector test has finished.


It's a bit sad that we can't use the public API to properly hide/show the
inspector but have to resort to private drt hooks :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.