[Webkit-unassigned] [Bug 34160] [Qt] Add support for Maemo zoom keys in QtLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34160


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47399|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2010-01-27 01:25:52 PST ---
(From update of attachment 47399)

> +
> +#ifdef Q_WS_MAEMO_5
> +    ~MainWindow()
> +    {
> +        grabZoomKeys(false);
>      }
> +#endif

I suggest to move the #ifdefs into the function body. (as well as in
keyPressEvent)

>  #if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
>      void sendTouchEvent()
> @@ -193,6 +209,9 @@ public:
>  
>      bool eventFilter(QObject* obj, QEvent* event)
>      {
> +        // MAEMO: The X11 headers macro "KeyPress" which breaks "QEvent::KeyPress"...
> +        const int QEvent_KeyPress = 6;

A better way to fix this is to #undef KeyPress after including the X11 headers.


The rest looks good to me :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.