[Webkit-unassigned] [Bug 33889] autobuffer value not forwarded media element to MediaPlayer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 00:40:20 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33889


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2010-01-27 00:40:20 PST ---
(In reply to comment #5)
> (From update of attachment 47341 [details])
> How do we test this?  Looks sane, but all changes should have tests or
> explanation as to why testing is impossible.

Well I am still new to this but I didn't see unittests for the MediaPlayer,
maybe it would make sense to have some? The MediaPlayerPrivate implementations
are not unittested either, afaics.

Anyway I landed this patch as r53910. I will think about unittesting the
MediaPlayer at least.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list