[Webkit-unassigned] [Bug 33840] Provide a way to get page number with layoutTestController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 23:04:56 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33840





--- Comment #7 from Shinichiro Hamaji <hamaji at chromium.org>  2010-01-26 23:04:56 PST ---
(In reply to comment #5)
> (From update of attachment 47157 [details])
> pageNumberForElement should take in a width/height, or maybe a Vector of
> IntSize's (since that's what other parts of this code use).

Thanks for your review! I modified my patch so the new method may take width
and height. I made them optional because some tests (e.g., tests for
page-break-*) won't care the size of pages. We may eventually want to add other
parameters  such as userScaleFactor, the size of physical pages (page size +
margin size, they would be necessary once we implement media queries like
"@media print and (width: 21cm)"
http://www.w3.org/TR/css3-page/#page-size-media-query), and etc. I'd like to
avoid adding them for now because I didn't figure out sufficient set of such
parameters yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list