[Webkit-unassigned] [Bug 34193] New: webkit-patch: Hangs on bad bugzilla username and completes?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34193

           Summary: webkit-patch: Hangs on bad bugzilla username and
                    completes?
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cjerdonek at webkit.org
                CC: eric at webkit.org, abarth at webkit.org


Looking at the webkit-patch issues, this one is probably already recorded
somewhere.

I had an experience where webkit-patch hung for a minute and terminated --
apparently because the bugzilla username in my keychain was out of date.  I
spent another 15 minutes trying to get webkit-patch to work, only to discover
later that the commit had already happened!  It looks like it got interrupted
while trying to mark the bug resolved.  It's bad because there is no line of
output saying anything like "Committed revision...." -- only "Processing patch
47411 from bug 34060."  It's hard to know this means "committed" because the
next output line says it is parsing the Changelog.  It seems like the ChangeLog
would be parsed before it starts committing.  It would also be good if the
error says what remaining steps didn't complete, so the user knows what
remaining steps need to be manually completed.

See below:

$ WebKitTools/Scripts/webkit-patch land-from-bug --no-build --ignore-builders
34060
Fetching: https://bugs.webkit.org/show_bug.cgi?id=34060&ctype=xml
1 reviewed patch found on bug 34060.
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 47411 from bug 34060.
Parsing ChangeLog: WebKitTools/ChangeLog
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to
continue...
Logging in as chris.jerdonek at gmail.com...
Traceback (most recent call last):
  File "WebKitTools/Scripts/webkit-patch", line 108, in <module>
    WebKitPatch().main()
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/multicommandtool.py",
line 299, in main
    return command.check_arguments_and_execute(options, args, self)
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/multicommandtool.py",
line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/commands/download.py",
line 116, in execute
    self._process_patch(patch, options, args, tool)
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/commands/download.py",
line 135, in _process_patch
    self._main_sequence.run_and_handle_errors(tool, options, state)
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/stepsequence.py",
line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/stepsequence.py",
line 60, in _run
    step(tool, options).run(state)
  File
"/Users/chris_g4/Dev/Apple/WebKit-svn/WebKitTools/Scripts/webkitpy/steps/closepatch.py",
line 36, in run
    self._tool.bugs.clear_attachment_flags(state["patch"].id(), comment_text)
  File
"/Users/chris_g4/dev/apple/WebKit-svn/WebKitTools/Scripts/webkitpy/bugzilla.py",
line 632, in clear_attachment_flags
    self.authenticate()
  File
"/Users/chris_g4/dev/apple/WebKit-svn/WebKitTools/Scripts/webkitpy/bugzilla.py",
line 476, in authenticate
    "index.cgi?GoAheadAndLogIn=1")
  File
"./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_mechanize.py",
line 209, in open
  File
"./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_mechanize.py",
line 236, in _mech_open
  File
"./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_opener.py",
line 191, in open
  File
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py",
line 401, in _open
    '_open', req)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py",
line 361, in _call_chain
    result = func(*args)
  File
"./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_http.py",
line 756, in https_open
  File
"./autoinstall.cache.d/-7171706890285649816/mechanize-0.1.11.zip/mechanize-0.1.11/mechanize/_http.py",
line 706, in do_open
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>
stonewall:WebKit-svn chris_g4$

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.