[Webkit-unassigned] [Bug 34189] New: check-webkit-style failed to complain about missing braces

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 16:07:00 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34189

           Summary: check-webkit-style failed to complain about missing
                    braces
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: evan at chromium.org


This patch:
https://bugs.webkit.org/show_bug.cgi?id=34186#c1

had this diff:

         ASSERT(U_SUCCESS(error));
+        for (unsigned i = 0; i < normalizedString.length(); ++i)
+            if (Font::treatAsSpace(m_normalizedBuffer[i]))
+                m_normalizedBuffer[i] = ' ';


Which I'm informed lacks parens.  But the style bot didn't mind it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list