[Webkit-unassigned] [Bug 34160] [Qt] Add support for Maemo zoom keys in QtLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34160


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dbates at webkit.org




--- Comment #3 from Daniel Bates <dbates at webkit.org>  2010-01-26 15:37:28 PST ---
I am not too familiar with Maemo or its supported devices, but is there a
reason why you chose the keys F7 and F8 for zooming in and out, respectively,
as opposed to conforming to the + and - keys used currently by QtLauncher,
Safari, and Firefox?

Also, wouldn't this change break current functionality:

-        } else if (event->type() == QEvent::KeyPress
+        } else if (event->type() == QEvent_KeyPress

You seem to point this out by your comment:
// MAEMO: The X11 headers macro "KeyPress" which breaks "QEvent::KeyPress"...

Moreover, can you elaborate what you implying by the "..."?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.