[Webkit-unassigned] [Bug 34167] [Qt] DRT WebHistory support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34167





--- Comment #2 from Diego Gonzalez <diego.gonzalez at openbossa.org>  2010-01-26 09:36:32 PST ---
The tests is not passing with the patch above (47412) because in the redirect
file page (LayoutTests/http/tests/history/resources/redirect-target.html) the
webHistoryItemCount is increased in one according the code below.

function testHistoryItemCount()
{
    var expected = parseInt(location.hash.slice(1));
    var actual = layoutTestController.webHistoryItemCount + 1; // Add one to
include the referring page, which loaded before we started recording history.
    if (actual === expected)
        log("PASS: History item count should be " + expected + " and is.");
    else
        log("FAIL: History item count should be " + expected + " but instead is
" + actual + ".");
}

In our case is not necessary to add one to webHistoryItemCount because
QWebHistory, created in QWebPage, records the referred page.

One possible way to make the tests succeed is use specific expected files for
Qt port use in these tests.

Other ways coukd be: decrease in one the return of
layoutTestController.webHistoryItemCount(); use the backItems() size; or limit
the maximum count of QWebHistory.

Someone has any suggestion or comment of the the best way to solve it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.