[Webkit-unassigned] [Bug 34019] Custom-written JavaScript parser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34019





--- Comment #12 from Zoltan Herczeg <zherczeg at webkit.org>  2010-01-25 14:06:14 PST ---
I am thinking about the future of this work. I will do layout and performance
testings tommorrow, but still meany other tasks ahead. Would be good to broke
this patch to smaller pieces, but it doesn't seem possible, since everything is
needed. I cannot cut out things, like 'switch', 'for' or 'function' parsing.
Since this is a huge piece of code, probably many things will be needed to
improve, like changing variable names, restructure code. This will need a lot
of reviewer effort, which I thank for in advance.

I planned this parser to be robust and future proof. It seems these advantages
are put in good use sooner than I expected. Such things are strict JS parsing
or generating AST for nested function bodies. However, it would be better to do
them in separate patches, than doing everything in an all in-one package.
Probably would be better to start these works after I got some feedback about
the code.

I have one question about function nesting. We use
ParserArenaData<DeclarationStacks::...> variables in the code, but the
FunctionBodyNode expects DeclarationStacks::... variables. What would be a good
solution for this difference?

Anyway, although the code is big, the concept behind it is very simple. A
step-by-step debugging on simple JS sources can reaveal easly how it works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.