[Webkit-unassigned] [Bug 34029] REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34029





--- Comment #7 from Adele Peterson <adele at apple.com>  2010-01-25 11:52:44 PST ---
> > +            case CSSSelector::PseudoValid: {
> > +                if (!e)
> > +                    return false;
> > +                e->document()->setConsiderValidity();
> > +                return e->willValidate() && e->isValidFormControlElement();
> > +            } case CSSSelector::PseudoInvalid: {
> > +                if (!e)
> > +                    return false;
> > +                e->document()->setConsiderValidity();
> > +                return e->willValidate() && !e->isValidFormControlElement();
> > +            } case CSSSelector::PseudoChecked: {
> 
> No braces needed here. It's also strange to put the end brace on the same line
> as the case. Not our usual style, I don't think.

That's the style used in the rest of the method for cases with multiple lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.