[Webkit-unassigned] [Bug 33590] [GTK] GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33590





--- Comment #21 from Xan Lopez <xan.lopez at gmail.com>  2010-01-25 04:33:34 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > > WebCore/bindings/gobject/webkitdomstringconvert.h -> perhaps this should
> > > actually go inside WebCore/platform/gtk, since it is useful everywhere =).
> > 
> > Yeah, I think I even said the same thing in the old bug. Maybe we can do
> > another patch adding that file only and changing code in genera to use it?
> 
> Sounds like a great idea to me!
> 

A quick update on this: on further reflection this is not such a great idea
because, a) the functions can only be made to work if they strdup the char data
(otherwise the char data dies when you temporary CString we create goes out of
scope) b) the cases were we want to explicitly strdup the data are really few,
in the vast majority of cases the data is duped in the function you pass the
const char* data too.

So after talking with Gustavo we have decided to leave things like they are for
now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.