[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33096





--- Comment #37 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2010-01-25 04:10:30 PST ---
> > diff --git a/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp b/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
> > index 1caf96d..6e3bd5c 100644
> > --- a/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
> > +++ b/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
> > @@ -120,6 +120,9 @@ void InspectorClientQt::showWindow()
> >  void InspectorClientQt::closeWindow()
> >  {
> >  #if ENABLE(INSPECTOR)
> > +    // QWebInspector::frontEnd is a copy of inspectorView which will be left dangling
> > +    // by m_frontend.set(0) in InspectorController::close() if we do not clear it here.
> > +    m_inspectedWebPage->d->getOrCreateInspector()->d->setFrontend(0);
> >      m_inspectedWebPage->d->inspectorController()->setWindowVisible(false);
> >  #endif
> 
> Jocelyn, does that look okay to you? (you have a better idea of the inspector
> workings than I do :)
> 

>From my understanding, calling m_frontend.set(0) should have no effect on the
life of InspectorClientQt::m_inspectorView (and QWebInspector's frontend).
InspectorController::m_frontend is a proxy object to call javascript functions
and forward data in the inspector web page.

Were you able to make it crash without this line just by running the tests?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.