[Webkit-unassigned] [Bug 33150] Do not render the full frame when there is some elements with fixed positioning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 23 15:43:24 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33150


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47270|0                           |1
        is obsolete|                            |
  Attachment #47270|review?, commit-queue?      |
               Flag|                            |
  Attachment #47283|                            |review?, commit-queue?
               Flag|                            |




--- Comment #48 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-01-23 15:43:21 PST ---
Created an attachment (id=47283)
 --> (https://bugs.webkit.org/attachment.cgi?id=47283)
Repaint only the invalidated area after scrolling

Updated the patch with the comment of Simon

(In reply to comment #46)
> AFAICT here we are allocating the vector buffer on the speak. Once only, but
> it's still a (fastmalloc'ed) heap allocation, that is technically not needed.
> We know the size of the buffer, an allocation on the stack is cheaper,
> especially for the little amount it takes (5 pointers + alignment). 

That's a very good idea.

> Why not use Vector's inline capacity feature:
> 
>      Vector<RenderObject*, fixedObjectNumberThreshold> fixedObjectsInViewport;
> 
> If I understand the wtf::Vector code correctly that will allocate the vector's
> buffer nicely on the stack.

That's a very cool feature :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list