[Webkit-unassigned] [Bug 33971] Check base URI validity before using in SVGImageLoader::sourceURI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33971





--- Comment #3 from Bryan Yeung <bryeung at chromium.org>  2010-01-22 11:35:58 PST ---
Darin:

Thanks for taking the time to look at my patch, and sorry: I should have
included a bit more context around this issue.

I don't think that the code you suggest addresses the problem that I see:
element()->baseURI() is an invalidated KURL object whenever the SVG element
does not have an xml:base specified.  The code works anyway, because the
relative path is still available from the invalidated URL, but it seems
dangerous/wrong to make use of invalidated objects.  (I've created a separate
bug to track this behaviour of KURL:
https://bugs.webkit.org/show_bug.cgi?id=34011).  Maybe I'm just
misunderstanding what it means for a KURL to be invalidated?

Further, all of the other subclasses of ImageLoader return the result of
deprecatedParseURL.  If you're suggesting that this is incorrect, it will
presumably need to be fixed everywhere (and has been wrong for quite some
time...since rev 36712 which introduced the sourceURI method).

I completely agree about the test case: I'll update the patch in a bit to
include a new layout test that has images with and without a base URI
specified.

Thanks again,

Bryan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.