[Webkit-unassigned] [Bug 32722] Allow Reserved Words in Property Accessors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32722





--- Comment #31 from Oliver Hunt <oliver at apple.com>  2010-01-22 11:16:57 PST ---
(In reply to comment #30)
> (In reply to comment #29)
> > (In reply to comment #28)
> > > Recently Zoltan said he was working on a custom-written parser to replace the
> > > Bison one.
> > 
> > That would obviously make this patch moot.  But the test case can be reused.
> 
> Yeah, I am working on a new parser. The patch is 270k now, 110k to remove
> grammar.y, but the remaining is new code. Will be a reviewers nightmare :D
> There is 271 regressions so far, because there are still some complicated JS
> statement is not yet finished (namely: try, switch, object-literal). And still
> I am not sure what the ArgumentsFeature means. There is another 55k patch which
> dumps the AST to a text file which is used for regression testing (although
> could be interesting for the others to actually see the tree). The hand written
> parser is ~ 3x faster for regular code, and ~ 4x faster for syntax checking
> (was NoNode rules in grammar.y). Would be also good to have syntax error
> regression tests (like: 3 = 2 is ok, while -3 = 2 is parse error, 'do ;
> while(0) ++i is' ok, but 'for (var a, b in c) {}' is a parse error.). Actually
> the 'for' was the worst to parse, since it has so many valid and invalid forms.
> 
> I didn't know that keywords can be used after a dot, and in the object literal.
> I will probably need a keyword to ident converter, and append all of these
> tokens to CommonIdentifiers.
It would be good if you could put your patch up for feedback, rather than
writing the entire thing in a vacuum - I had been planning on rewriting the
parser in a recursive descent form as that's necessary for strict mode support
so it would be good to see what your hand rolled parser is doing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.