[Webkit-unassigned] [Bug 34003] [GTK] Pass cookies to GStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34003





--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org>  2010-01-22 09:58:13 PST ---
(In reply to comment #4)
> (From update of attachment 47203 [details])
> In addition to the style checker output (which seems valid for the case), I
> have the following comments:
> 
>  132     g_object_get (mp->m_playBin, "source", &element, NULL);
>  133     old_element = mp->m_source;
>  134     mp->m_source = NULL;
> 
> The old_element variable (besides having a bad name given the style) seems to
> be unnecessary. You could check, and unref mp->m_source directly instead of
> assigning it to another variable.

Ok :)

>  135     if (old_element)
>  136         gst_object_unref (old_element);
>  137     mp->m_source = element;
> 
> This looks like a crash - we are not refing the element ourselves (perhaps we
> should), so unreffing it seems wrong (the same goes for the destructor).

g_object_get will ref the element for us


(In reply to comment #5)
> Dan Winship told me yesterday that another solution would be to copy the webkit
> soup session and hand it to gstreamer.
> 
> I believe this solution would be more future-proof, because at some point we
> will need more context: referrer, auth/ssl, proxy (not sure if it's relevant
> for webkit/gnome, but that's the idea)...

Problem with this is, that SoupSession is not threadsafe unfortunately

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.