[Webkit-unassigned] [Bug 33590] [GTK] GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33590





--- Comment #19 from Gustavo Noronha (kov) <gns at gnome.org>  2010-01-22 09:05:05 PST ---
(In reply to comment #18)
> > WebCore/bindings/gobject/webkitdomstringconvert.h -> perhaps this should
> > actually go inside WebCore/platform/gtk, since it is useful everywhere =).
> 
> Yeah, I think I even said the same thing in the old bug. Maybe we can do
> another patch adding that file only and changing code in genera to use it?

Sounds like a great idea to me!

> > 171 sub GetGlibTypeName {
> > 
> > Why use char* and gchar elsewhere here? We are also using gint, and such here,
> > it would be good to be consistent
> 
> I'm not sure I understand the comment. Do you think we should NOT use the
> g-prefixed types here? Or we should? I don't like them in general when they are
> useless (char vs gchar, etc), but I stuck with them because that's our code
> style in WebKit as far as I remember.

No, I agree on using them. I'm just pointing out that you are using
non-g-prefixed char in the first line:

+    my %types = ("DOMString", "char* ",
+                 "float", "gfloat",
+                 "double", "gdouble",
+                 "boolean", "gboolean",
+                 "char", "gchar",

DOMString is mapped to char*, while char is mapped to gchar =). Make the
DOMString a gchar*, perhaps.

> I was actually just copying the existing style, in other files when there were
> (say) COM and OBJECTIVE_C #ifs, each one would be in one line IIRC. I have no
> strong opinion about this, other than noting than putting them in the same line
> makes for a really long line.

I don't have a strong opinion either. If that is what current code already
does, I'm fine.

> Yeah, we should have Sam or Mark take a look at it.

Now we just need to grab one of them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.