[Webkit-unassigned] [Bug 33957] [v8] Implement Node map in intrusive way for better speed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33957


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #8 from David Levin <levin at chromium.org>  2010-01-22 08:46:41 PST ---
(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 47126 [details] [details])
> > + if (!wrapper) return v8::Persistent<v8::Object>();
> > 
> > Should be two lines.  (This nit repeated many times.)
> 
> Hopefully fixed all those, sorry.  Just curious, how difficult it'd be to add
> this check into style-checking script?

Simply an issue of figuring out an appropriate regex/code to detect this and
putting it in the style checking script (along with an appropriate error
category and test). The hardest part is the correct detection (which may not be
too hard). If you'd like to do it, that would be great, imo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.