[Webkit-unassigned] [Bug 33967] [GTK] Mute/unmute button on <video> elements are backwards

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 00:10:52 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33967





--- Comment #4 from Mike Hommey <mh+webkit at glandium.org>  2010-01-22 00:10:52 PST ---
(In reply to comment #3)
> (From update of attachment 47138 [details])
> Every change requires a ChangeLog.  see
> http://webkit.org/coding/contributing.html

I know that ;)

I first wanted to know how this should be fixed. We seem to agree on the fact
that the variable names are ambiguous. 
How about renaming them to a past participle form as proposed in comment #0 ?
(m_mutedButton, m_pausedButton, etc.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list