[Webkit-unassigned] [Bug 33979] -webkit-mask-box-image draws a box while loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33979


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47160|review?                     |review+
               Flag|                            |




--- Comment #2 from mitz at webkit.org  2010-01-21 17:16:55 PST ---
(From update of attachment 47160)
Change looks fine. Resorting to nit-picking.

> +        <rdar://problem/7378662>
> +        
> +        
> +
> +        * http/tests/misc/resources/slow-png-load.pl: Added.

Too many newlines.

> \ No newline at end of file

Too few newlines.

> +        * rendering/RenderBox.cpp:
> +        (WebCore::RenderBox::paintMaskImages):
> +        * rendering/style/FillLayer.cpp:
> +        (WebCore::FillLayer::areImagesLoaded):
> +        * rendering/style/FillLayer.h:

Explain what you did there?

> +    bool areImagesLoaded() const;

I prefer imagesAreLoaded() or hasLoaded[All]Images().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.