[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831


Brian Tarricone <bjt23 at cornell.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42765|0                           |1
        is obsolete|                            |
  Attachment #47162|                            |review?
               Flag|                            |




--- Comment #45 from Brian Tarricone <bjt23 at cornell.edu>  2010-01-21 17:16:36 PST ---
Created an attachment (id=47162)
 --> (https://bugs.webkit.org/attachment.cgi?id=47162)
gtk windowless v6

Finally found some time to get back to this.

Changes from v5:

* Applies cleanly to git master as of today.
* I think I've addressed all the style issues and questions in the comments; if
not, please let me know.
* Don't use GDK when painting the Pixmap to the window after the plugin has
painted to it.  The API for creating a foreign GdkPixmap is kinda broken IMO,
and it's just as easy to create a cairo_surface_t from the X Pixmap.
* When in transparent mode AND the Pixmap passed to the plugin has a 32bpp
depth, clear the expose region of the Pixmap to fully transparent before
passing it to the plugin.  Without this, you end up with junk in the Pixmap
anywhere where the plugin paints anything with transparency.
* Use the root window when creating the Pixmap instead of GDK_WINDOW_XID() on
the parent widget.  XCreatePixmap() just uses the window to figure out which
screen it's on, and GDK_WINDOW_XID() will force the GdkWindow to create a
backing native Window on GTK+ 2.18 and above.

I left in the hack regarding the expose rect in based on Girish's agreement
that it can do no harm and is possibly necessary for Adobe Flash.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.