[Webkit-unassigned] [Bug 33230] svg/W3C-SVG-1.1/animate-elem-30-t.svg crashing occasionally on Leopard Build Bot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33230





--- Comment #24 from Darin Adler <darin at apple.com>  2010-01-21 16:29:39 PST ---
(In reply to comment #23)
> (In reply to comment #22)
> > > SVG does this:
> > > http://trac.webkit.org/browser/trunk/WebCore/rendering/SVGRenderSupport.cpp#L253
> > 
> > Has always been incorrect and is a serious design problem.
> 
> Huh?
> 
> Every RenderBlock calls child->layoutIfNeeded(), from it's own layout() method.
> Where is the problem here? We're only layouting the subtree, no one retriggers
> a root layout from the middle of a layout.

Sorry, I was in a rush did not look at the code and probably said the wrong
thing.

It's wrong to trigger additional layout that will still not be complete at the
end of the layout process. The code above is likely correct if it fits into the
normal layout process.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.