[Webkit-unassigned] [Bug 33957] [v8] Implement Node map in intrusive way for better speed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33957


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47126|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-01-21 16:28:56 PST ---
(From update of attachment 47126)
+ if (!wrapper) return v8::Persistent<v8::Object>();

Should be two lines.  (This nit repeated many times.)

+ TableChunk

Why not just use Vector?

+ virtual v8::Persistent<ValueType> get(KeyType* obj)

Are these methods already virtual?  It seems like we shouldn't need that.  We
should be able to use templates to solve the dispatch problem at compile time.

r- for style, but curious about the above questions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.