[Webkit-unassigned] [Bug 33967] New: Mute/unmute button on <video> elements are backwards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33967

           Summary: Mute/unmute button on <video> elements are backwards
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mh+webkit at glandium.org


The button was added as part of #26304.

When the sound is muted, the icon displays the "audio-volume-high" icon, and on
the contrary, when the sound is unmuted, the "audio-volume-muted" icon is
displayed. While when you read the latter this way it can sound normal, it
actually makes no sense, because it doesn't reflect the current state of the
sound.

The patch I'm attaching will fix the obvious problem, but I think the variable
names should be changed to something that makes it more obvious, like
"m_mutedButton" and "m_unmutedButton" (which would reverse their meaning).

What do you think ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.