[Webkit-unassigned] [Bug 33943] Use fastStrDup instead of strdup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33943





--- Comment #4 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-01-21 03:02:55 PST ---
The following files still contain strdup after this patch.

 - bindings/v8/npruntime.cpp
 - bridge/npruntime.cpp
 - bindings/v8/V8NPUtils.cpp


NPN_UTF8FromIdentifier uses strdup to duplicate a string, so the returned
memory must be freed with NPN_MemFree. As NPN_MemFree is implemented with free,
strdup can't be replaced with fastStrDup.

Technically speaking, we can change NPN_MemAlloc/NPN_MemFree to use
fastMalloc/fastFree internally and use fastStrDup in  NPN_UTF8FromIdentifier.
However, some plugins use free instead of NPN_MemFree, replacing strdup with
fastStrDup breaks those plugins.

NPN_ReleaseVariantValue has the same issue as NPN_UTF8FromIdentifier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.