[Webkit-unassigned] [Bug 33755] Make update-iexploder-cssproperties update htmltags.in and htmlattrs.in as well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33755





--- Comment #3 from Holger Freyther <zecke at selfish.org>  2010-01-20 21:37:50 PST ---
(In reply to comment #1)

I should have addressed all comments form above (sorting, naming, bug id).


> I just realized you could make this more generic by using a hash to hold these
> values, then just iterate over the hash in a single update() method.

I'm not sure if I follow here? We are writing three different files so the hash
would be the input to the method?



> If you'd rather keep separate methods, please add them before
> writeiExploderFile() to keep the subroutines alphabetized.

I nuked them. And I also append the path for htmldocs and WebCore inside the
update method.


> r- to consider all the minor issues here.  (I'd like to be able to cq+ the
> patch when finished. :)

I'm fine to land the patch myself. :)



As follow up commits we should rename the file, and I'm working on a commit to
automatically append deleted entities to the end of the file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.