[Webkit-unassigned] [Bug 33926] New: WebDownloadCFNet doesn't remember the overwrite setting from setDownload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33926

           Summary: WebDownloadCFNet doesn't remember the overwrite
                    setting from setDownload
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: grimm at xqdev.com
                CC: aroben at apple.com


Created an attachment (id=47078)
 --> (https://bugs.webkit.org/attachment.cgi?id=47078)
Sample code to help reproducing the bug

If you create a download delegate that sets the download->setDestination
allowOverwrite argument to true and the file exists, the file will not actually
be overridden.  This happens because the MoveFileEx call in the didFinish
method of WebDownloadCFNet.cpp always passes 0 as the third argument when it
should pass MOVEFILE_REPLACE_EXISTING when allowOverwrite was set to true.

I'm including some stripped down code that should be able to reproduce the
issue.  Just split the file out into .cpp and .h files and call the
ManualDownload() function passing in any url.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.