[Webkit-unassigned] [Bug 33911] HTMLInputElement::valueAsDate setter support for type=date.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33911


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47046|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-01-20 16:21:16 PST ---
(From update of attachment 47046)
> +    if (beforeGregorianStartDate(m_year, m_month, m_monthDay))
> +        return false;

It seems bad that in this case the function returns false, but has already had
a side effect and changed the state of the ISODateTime object. Ideally
functions would either succeed or leave the object untouched. In this patch
there seems no problem with the behavior, but it is surprising to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.