[Webkit-unassigned] [Bug 33900] [Gtk] media/video-play-pause-exception.html is flacky

Wed Jan 20 08:29:45 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=33900

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47024|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2010-01-20 08:29:44 PST ---
(From update of attachment 47024)
> +<html>
> +<body>

This seems like a pointless change to me; including explicit HTML and body
elements does not make our tests better. I assume it has no effect on the test.

> +    waitForEvent("pause", onpause);

It seems to me we should call waitForEvent("pause") before calling video.play()
and video.pause().

I would not have preserved the blank line at the end of the test created with
consoleWrite.

I would probably have used waitForEventTestAndEnd.

Seems OK as is. r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.