[Webkit-unassigned] [Bug 28933] bugzilla-tool post-commits should not remove r- flag.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 17:06:14 PST 2010


--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-01-19 17:06:13 PST ---
We can't leave r+ on obsolete patches due to our inability to make a "patches
to land" query which excludes obsolete patches.  See

Why would we need to leave any r+/r-/r? information on obsolete patches?  That
information is never lost.  Its easily viewable from the history if needed. 
(e.g. https://bugs.webkit.org/show_activity.cgi?id=32920)  If you'd like, we
could easily make the obsolete method in bugzilla.py (used by webkit-patch)
make a comment about who had marked it r-.

It's an easy change to make it leave the r-, but I'm not sure it's much value. 
Ideally we wouldn't be limited by bugzilla and we would just leave whatever
flags we wanted on obsolete patches.  But unless we can fix bugzilla to filter
them out of our "patches to review" and "patches to commit" queries, humans get
confused when we leave these flags around.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list