[Webkit-unassigned] [Bug 32896] [bzt] Bugzilla-tool should not try to get the username and password from Git when we're using SVN

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32896





--- Comment #10 from Eric Seidel <eric at webkit.org>  2010-01-19 16:18:33 PST ---
This broke a couple scm.py unit tests:
ERROR: test_error_handlers (webkitpy.scm_unittest.SCMClassTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/scm_unittest.py",
line 150, in test_error_handlers
    self.assertRaises(OSError, run_command, command_does_not_exist)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
line 320, in failUnlessRaises
    callableObj(*args, **kwargs)
  File
"/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/executive.py",
line 70, in run_command
    return Executive().run_command(*args, **kwargs)
  File
"/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/executive.py",
line 142, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File
"/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/executive.py",
line 113, in default_error_handler
    raise error
ScriptError: Failed to run "['does_not_exist', 'invalid_option']" exit_code: 2

I'm not sure catching OSError here is a good idea.  It turns missing scripts
into "exit code 2" which happens to be the same as
QueueEngine.handled_error_code = 2

We obviously could change handled_error_code....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.