[Webkit-unassigned] [Bug 32189] [GTK] Integrate running of API tests into buildbot run

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 15:20:14 PST 2010


--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2010-01-19 15:20:13 PST ---
Thanks for the review!

(In reply to comment #2)
> (From update of attachment 44353 [details])
> We have shared code for how to get the configuration directory in
> webkitdirs.pm.  I think we should re-use that here.  Meaning we should just
> make run-gtk-tests a perl script.  Unfortunately we don't have any equivalent
> detection code for python or I would suggest we write this in python instead.
> :)

OK; I was kind of avoiding this, but I think it makes sense to keep this kind
of logic in a centralized place.

> No need to call bash directly, or?
> +    command = ["bash", "./WebKitTools/Scripts/run-gtk-tests",
> WithProperties("--%(configuration)s")]

That's to keep consistency. Perl also theoretically does not need to be called
directly, but all commands include it explicitely.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list